Skip to content

Bugfix: removed redundant unlock, potentially causing double unlock#4928

Merged
algorandskiy merged 1 commit intoalgorand:masterfrom
almog-t:bugfix/fix-potential-double-unlock
Dec 21, 2022
Merged

Bugfix: removed redundant unlock, potentially causing double unlock#4928
algorandskiy merged 1 commit intoalgorand:masterfrom
almog-t:bugfix/fix-potential-double-unlock

Conversation

@almog-t
Copy link
Copy Markdown
Contributor

@almog-t almog-t commented Dec 21, 2022

No description provided.

@almog-t almog-t requested a review from algorandskiy December 21, 2022 07:49
@almog-t almog-t changed the title removed redundant unlock, potentially causing double unlock Bugfix: removed redundant unlock, potentially causing double unlock Dec 21, 2022
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 21, 2022

Codecov Report

Merging #4928 (bfcb94b) into master (34a12e3) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4928      +/-   ##
==========================================
+ Coverage   53.52%   53.53%   +0.01%     
==========================================
  Files         432      432              
  Lines       53616    53615       -1     
==========================================
+ Hits        28698    28704       +6     
+ Misses      22692    22686       -6     
+ Partials     2226     2225       -1     
Impacted Files Coverage Δ
ledger/acctonline.go 78.64% <ø> (-0.32%) ⬇️
network/wsPeer.go 67.06% <0.00%> (-2.15%) ⬇️
catchup/peerSelector.go 98.95% <0.00%> (-1.05%) ⬇️
network/wsNetwork.go 64.74% <0.00%> (-0.18%) ⬇️
ledger/testing/randomAccounts.go 56.26% <0.00%> (ø)
data/transactions/verify/txn.go 74.57% <0.00%> (+0.84%) ⬆️
agreement/proposalManager.go 98.03% <0.00%> (+1.96%) ⬆️
agreement/cryptoVerifier.go 69.71% <0.00%> (+2.11%) ⬆️
ledger/tracker.go 78.90% <0.00%> (+2.95%) ⬆️
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Copy Markdown
Contributor

@algorandskiy algorandskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@algorandskiy algorandskiy merged commit 3fbe53c into algorand:master Dec 21, 2022
@almog-t almog-t deleted the bugfix/fix-potential-double-unlock branch December 28, 2022 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants